[PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao added a comment. In D21856#1338687 , @thakis wrote: > Sorry about the years-later question, but what's the motivation for shelling > out to an external command here? In general, LLVM tries to use a > library-based approach, and LLVM went e.g.

[PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

thakis added a comment. Herald added a subscriber: guansong. Sorry about the years-later question, but what's the motivation for shelling out to an external command here? In general, LLVM tries to use a library-based approach, and LLVM went e.g. through great lengths do use an integrated

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D21856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

ABataev added a comment. LG https://reviews.llvm.org/D21856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao updated this revision to Diff 72125. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h lib/Driver/Action.cpp lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp lib/Driver/Tools.h

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao updated this revision to Diff 66028. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h lib/Driver/Action.cpp lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp lib/Driver/Tools.h

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao updated this revision to Diff 62590. sfantao added a comment. - Start static function name with caps. http://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h lib/Driver/Action.cpp lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao updated this revision to Diff 62567. sfantao added a comment. - Use StringRef instead of std::string, fix comments and mark class final. http://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h lib/Driver/Action.cpp

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/Driver/Action.cpp:133 @@ +132,3 @@ +/// we assume 'host'. +std::string Action::getOffloadKindName(OffloadKind Kind) { + switch (Kind) { ABataev wrote: > 1. Maybe it is enough to return

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao updated this revision to Diff 62561. sfantao marked 3 inline comments as done. sfantao added a comment. - Use StringRef instead of string and mark bundler tool as final. http://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h

[PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao created this revision. sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev. sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, andreybokhanko, Hahnfeld, cfe-commits. Herald added a subscriber: mehdi_amini. This patch adds the support to create a job for the