Re: [PATCH] D21871: [libcxx] [test] Make vector.bool/construct_default.pass.cpp more portable.

2016-07-01 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT abandoned this revision. STL_MSFT added a comment. Nah, they can totally be noexcept like the primary template. Usually we don't strengthen beyond the WP, but the wording is so clearly defective here, I'll go ahead and do this. No test changes necessary now. http://reviews.llvm.org/D2

Re: [PATCH] D21871: [libcxx] [test] Make vector.bool/construct_default.pass.cpp more portable.

2016-06-29 Thread Eric Fiselier via cfe-commits
EricWF added a comment. The fact that they are not noexcept in the working paper seems like an oversight. Is there a reason your vector default constructor can't be noexcept? http://reviews.llvm.org/D21871 ___ cfe-commits mailing list cfe-commits@

[PATCH] D21871: [libcxx] [test] Make vector.bool/construct_default.pass.cpp more portable.

2016-06-29 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make vector.bool/construct_default.pass.cpp more portable. vector's default ctor and allocator ctor aren't depicted as noexcept in the Working Paper. We're already directly in