Re: [PATCH] D22017: [libcxx] [test] Work around MSVC's non-Standard ABI for enums.

2016-07-24 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r276589. https://reviews.llvm.org/D22017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22017: [libcxx] [test] Work around MSVC's non-Standard ABI for enums.

2016-07-24 Thread Eric Fiselier via cfe-commits
EricWF added a comment. I'll check in this fix with the suggested change. https://reviews.llvm.org/D22017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22017: [libcxx] [test] Work around MSVC's non-Standard ABI for enums.

2016-07-24 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. > in underlying_type.pass.cpp, I'm simply marking the affected static_asserts > as libcxx-specific (this probably won't be sufficient when you try to get the > Clang/LLVM/libcxx stack running

[PATCH] D22017: [libcxx] [test] Work around MSVC's non-Standard ABI for enums.

2016-07-05 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Work around MSVC's non-Standard ABI for enums. So this is definitely an MSVC bug, but one that's baked into our layout behavior, so even Clang has to enable it