Re: [PATCH] D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver

2016-07-08 Thread Yaxun Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274923: [OpenCL] Add missing -cl-no-signed-zeros option into driver (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D22067?vs=63143=63308#toc Repository: rL LLVM

Re: [PATCH] D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver

2016-07-08 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! http://reviews.llvm.org/D22067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver

2016-07-08 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. LGTM. Thanks. http://reviews.llvm.org/D22067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver

2016-07-07 Thread Aaron En Ye Shi via cfe-commits
ashi1 added a reviewer: yaxunl. ashi1 removed rL LLVM as the repository for this revision. ashi1 updated this revision to Diff 63143. ashi1 added a comment. Revised base on Sam's comments. Added no-signed-zeros as an attribute no-signed-zeros-fp-math. Added a test for no-signed-zeros-fp-math.

Re: [PATCH] D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver

2016-07-06 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. I think you also need to set Opts.NoSignedZeros in CompilerInvocation.cpp. Repository: rL LLVM http://reviews.llvm.org/D22067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver

2016-07-06 Thread Aaron En Ye Shi via cfe-commits
ashi1 created this revision. ashi1 added reviewers: Anastasia, jvesely. ashi1 added subscribers: yaxunl, nhaustov, rsmith, bader, pxli168, cfe-commits. ashi1 set the repository for this revision to rL LLVM. Add OCL option -cl-no-signed-zeros to driver options. Also added to opencl.cl testcases.