This revision was automatically updated to reflect the committed changes.
Closed by commit rL278553: [clang-tidy] MPIBufferDerefCheck (authored by
Alexander_Droste).
Changed prior to commit:
https://reviews.llvm.org/D22729?vs=66971=67884#toc
Repository:
rL LLVM
Alexander_Droste added a comment.
No but I guess it would be a good idea to ask for commit access.
I'll proceed like suggested here:
http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access.
https://reviews.llvm.org/D22729
___
cfe-commits
hokein added a comment.
Do you have commit access now?
https://reviews.llvm.org/D22729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alexander_Droste added a comment.
Great; thanks again for the review!
https://reviews.llvm.org/D22729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D22729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Alexander_Droste updated this revision to Diff 66971.
Alexander_Droste marked an inline comment as done.
Alexander_Droste added a comment.
- check for `nullptr` in `addBuffer`
https://reviews.llvm.org/D22729
Files:
clang-tidy/mpi/BufferDerefCheck.cpp
clang-tidy/mpi/BufferDerefCheck.h
Alexander_Droste marked an inline comment as done.
Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:88
@@ +87,3 @@
+while (true) {
+ if (BufferType->isPointerType()) {
+BufferType = BufferType->getPointeeType().getTypePtr();
I just realized, you
Alexander_Droste updated this revision to Diff 66940.
Alexander_Droste marked 3 inline comments as done.
Alexander_Droste added a comment.
- add release docs
- simplify reverse for loop -> `rbegin`, `rend`
https://reviews.llvm.org/D22729
Files:
clang-tidy/mpi/BufferDerefCheck.cpp
Alexander_Droste marked 4 inline comments as done.
Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:87
@@ +86,3 @@
+// Capture the depth and types of indirections for the passed buffer.
+while (true) {
+ if (BufferType->isPointerType()) {
hokein
hokein added inline comments.
Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:87
@@ +86,3 @@
+// Capture the depth and types of indirections for the passed buffer.
+while (true) {
+ if (BufferType->isPointerType()) {
check whether `BufferType` is
Alexander_Droste updated this revision to Diff 66761.
Alexander_Droste added a comment.
- add needed extra line for docs
https://reviews.llvm.org/D22729
Files:
clang-tidy/mpi/BufferDerefCheck.cpp
clang-tidy/mpi/BufferDerefCheck.h
clang-tidy/mpi/CMakeLists.txt
Alexander_Droste updated this revision to Diff 66760.
Alexander_Droste added a comment.
- clarify lambda argument with comment
- explicit cast to `int` for the number of indirections in for loop
https://reviews.llvm.org/D22729
Files:
clang-tidy/mpi/BufferDerefCheck.cpp
Alexander_Droste marked 3 inline comments as done.
Alexander_Droste added a comment.
https://reviews.llvm.org/D22729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alexander_Droste added a comment.
Hi, thanks for having a look!
Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:63
@@ +62,3 @@
+if (FuncClassifier.isReduceType(Identifier)) {
+ addBuffer(0);
+ addBuffer(1);
hokein wrote:
> Could you add some
hokein added a comment.
Looks like the dependency of this patch https://reviews.llvm.org/D21962 got
reverted by some reasons.
Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:63
@@ +62,3 @@
+if (FuncClassifier.isReduceType(Identifier)) {
+ addBuffer(0);
+
Alexander_Droste updated this revision to Diff 65359.
Alexander_Droste added a comment.
- remove trailing whitespace
https://reviews.llvm.org/D22729
Files:
clang-tidy/mpi/BufferDerefCheck.cpp
clang-tidy/mpi/BufferDerefCheck.h
clang-tidy/mpi/CMakeLists.txt
Alexander_Droste updated this revision to Diff 65239.
Alexander_Droste added a comment.
- fix two MPIdatatype tags
https://reviews.llvm.org/D22729
Files:
clang-tidy/mpi/BufferDerefCheck.cpp
clang-tidy/mpi/BufferDerefCheck.h
clang-tidy/mpi/CMakeLists.txt
clang-tidy/mpi/MPITidyModule.cpp
Alexander_Droste updated this revision to Diff 65238.
Alexander_Droste added a comment.
- make `=` count accurate for `mpi-buffer-deref.rst`
https://reviews.llvm.org/D22729
Files:
clang-tidy/mpi/BufferDerefCheck.cpp
clang-tidy/mpi/BufferDerefCheck.h
clang-tidy/mpi/CMakeLists.txt
Alexander_Droste created this revision.
Alexander_Droste added a reviewer: alexfh.
Alexander_Droste added a subscriber: cfe-commits.
This check verifies if a buffer passed to an MPI (Message Passing Interface)
function is sufficiently dereferenced. Buffers should be passed as a single
pointer or
19 matches
Mail list logo
