[PATCH] D22973: [libcxx] [test] Add TEST_STACK_ALLOCATOR_WORKAROUND.

2016-10-10 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT abandoned this revision. STL_MSFT added a comment. Abandoning, as this machinery has been replaced. https://reviews.llvm.org/D22973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22973: [libcxx] [test] Add TEST_STACK_ALLOCATOR_WORKAROUND.

2016-10-01 Thread Eric Fiselier via cfe-commits
EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Nevermind. I decided to just fix stack_allocator so this patch is no longer needed. Please let me know if the stack allocator fix doesn't work https://reviews.llvm.org/D22973

[PATCH] D22973: [libcxx] [test] Add TEST_STACK_ALLOCATOR_WORKAROUND.

2016-09-30 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I'm OK accepting this, but I'm going to weak it before committing so that `test_macros.h` define `TEST_STACK_ALLOCATOR_WORKAROUND` for non-libc++ builds. https://reviews.llvm.org/D22973

[PATCH] D22973: [libcxx] [test] Add TEST_STACK_ALLOCATOR_WORKAROUND.

2016-09-30 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT added a comment. I know that this stack_allocator issue is a huge headache, but would it be possible to accept this small, non-intrusive diff upstream? This is the last local change that I have. https://reviews.llvm.org/D22973 ___

[PATCH] D22973: [libcxx] [test] Add TEST_STACK_ALLOCATOR_WORKAROUND.

2016-07-29 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Add TEST_STACK_ALLOCATOR_WORKAROUND. As I reported to Eric and Marshall: "stack_allocator is seriously nonconformant to N4582 17.6.3.5 [allocator.requirements]. First,