This revision was automatically updated to reflect the committed changes.
Closed by commit rL281355: ObjectiveC generics: Add ObjCTypeParamType in the
type system. (authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D23079?vs=69764=71197#toc
Repository:
rL LLVM
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
This looks great, thank you!
https://reviews.llvm.org/D23079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
manmanren added a comment.
Hi Doug,
Can you take a look at the updated version?
Thanks,
Manman
https://reviews.llvm.org/D23079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren updated this revision to Diff 69764.
manmanren added a comment.
Address Doug's comment. ObjCTypeParamType is a non-canonical type now, it is
canonicalized to the underlying type with protocol qualifiers.
https://reviews.llvm.org/D23079
Files:
include/clang/AST/ASTContext.h
doug.gregor added inline comments.
Comment at: include/clang/AST/RecursiveASTVisitor.h:1037
@@ -1036,1 +1036,3 @@
+DEF_TRAVERSE_TYPE(ObjCTypeParamType, {})
+
manmanren wrote:
> doug.gregor wrote:
> > I'm sorta shocked that we don't visit the protocol qualifiers
manmanren added a comment.
Thanks for reviewing!
Manman
Comment at: include/clang/AST/RecursiveASTVisitor.h:1037
@@ -1036,1 +1036,3 @@
+DEF_TRAVERSE_TYPE(ObjCTypeParamType, {})
+
doug.gregor wrote:
> I'm sorta shocked that we don't visit the protocol
doug.gregor requested changes to this revision.
doug.gregor added a comment.
This revision now requires changes to proceed.
A couple of comments above, but this is looking very good.
Comment at: include/clang/AST/RecursiveASTVisitor.h:1037
@@ -1036,1 +1036,3 @@
manmanren created this revision.
manmanren added a reviewer: doug.gregor.
manmanren added a subscriber: cfe-commits.
This depends on https://reviews.llvm.org/D23078
ObjC generics: Add ObjCTypeParamType in the type system.
We also need to add ObjCTypeParamTypeLoc. ObjCTypeParamType supports the
