Re: [PATCH] D23105: [clang/test] Fix a flaky unittest on windows

2016-08-03 Thread Reid Kleckner via cfe-commits
rnk added a comment. Thanks! lgtm Repository: rL LLVM https://reviews.llvm.org/D23105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23105: [clang/test] Fix a flaky unittest on windows

2016-08-03 Thread Etienne Bergeron via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL277576: [clang/test] Fix a flaky unittest on windows (authored by etienneb). Changed prior to commit: https://reviews.llvm.org/D23105?vs=66615=66616#toc Repository: rL LLVM

[PATCH] D23105: [clang/test] Fix a flaky unittest on windows

2016-08-03 Thread Etienne Bergeron via cfe-commits
etienneb created this revision. etienneb added a reviewer: rnk. etienneb added subscribers: chrisha, cfe-commits. The append operator on a shell command for quick command-line is causing trouble on windows. [NFC] The easiest way to fix them is to avoid using them. This patch is an attempt to fix