Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278101: Fix clang-tidy crash when a single fix is applied on multiple files. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D23257?vs=67292=67293#toc Repository: rL LLVM

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

ioeric updated this revision to Diff 67292. ioeric marked 4 inline comments as done. ioeric added a comment. - Nits fixed https://reviews.llvm.org/D23257 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

Prazek added a subscriber: Prazek. Prazek added a comment. I remember that it was pissing me off when I used clang-tidy first time. Thanks for fixing that! https://reviews.llvm.org/D23257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. A bunch of nits. Otherwise looks good. Thank you for the fix! Comment at: clang-tidy/ClangTidy.cpp:519 @@ -513,2 +518,3 @@ tooling::TranslationUnitReplacements TUR;

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

ioeric updated this revision to Diff 67193. ioeric marked 2 inline comments as done. ioeric added a comment. - Update test to not use https://reviews.llvm.org/D23257 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

alexfh added inline comments. Comment at: test/clang-tidy/Inputs/modernize-pass-by-value/header-with-fix.h:1 @@ +1,2 @@ +#include + hokein wrote: > Usually test should not use STL headers as it relies on the system headers. > > You don't have to use std::string

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

hokein added inline comments. Comment at: test/clang-tidy/Inputs/modernize-pass-by-value/header-with-fix.h:1 @@ +1,2 @@ +#include + Usually test should not use STL headers as it relies on the system headers. You don't have to use std::string to reproduce the

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

ioeric updated this revision to Diff 67164. ioeric marked 4 inline comments as done. ioeric added a comment. - Addressed reviewers' comments. https://reviews.llvm.org/D23257 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/ClangTidy.cpp:129 @@ -128,22 +128,3 @@ << Message.Message << Name; - for (const tooling::Replacement : Error.Fix) { -// Retrieve the

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

hokein added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.h:66 @@ -66,1 +65,3 @@ + // Fixes grouped by file path. + std::map Fix; SmallVector Notes; Use llvm::StringMap here?