Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. As discussed offline, since the functionality being added in this patch is only useful for tests, the related simplification of tests seems not worth the added complexity.

Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

zturner updated this revision to Diff 68404. zturner added a comment. Added full context diff. https://reviews.llvm.org/D23618 Files: include/clang/Tooling/CompilationDatabase.h include/clang/Tooling/JSONCompilationDatabase.h lib/Tooling/CommonOptionsParser.cpp

Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

Strange, I thought i did. Will re upload On Wed, Aug 17, 2016 at 12:14 PM Alexander Kornienko wrote: > alexfh added a comment. > > Full context diffs, please ( > http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface > ). > > >

Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

alexfh added a comment. Full context diffs, please (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface). https://reviews.llvm.org/D23618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

zturner created this revision. zturner added reviewers: djasper, alexfh, klimek. zturner added a subscriber: cfe-commits. Herald added a subscriber: klimek. Allow explicit specification of a compilation database file and source root. While trying to create a compilation database test for D23455,