Re: [PATCH] D23662: [libclang] Control whether crash recovery is enabled/disabled using function argument.

2016-09-28 Thread Argyrios Kyrtzidis via cfe-commits
akyrtzi added a comment. > I could disable crash recovery by calling clang_toggleCrashRecovery(false) > after clang_createIndex has been called but this doesn't work because the > right JVM handler isn't reinstalled Could you explain more why this doesn't work ? Is it a bug with the crash

Re: [PATCH] D23662: [libclang] Control whether crash recovery is enabled/disabled using function argument.

2016-09-28 Thread will via cfe-commits
wrmsr added a comment. I just lost a few days diagnosing what wound up being this :( In https://reviews.llvm.org/D23662#519445, @john.brawn wrote: > Surely the fix then is to make sure CrashRecoveryContext::Disable //does// > reinstall the right signal handler? The fix is to not do this by

Re: [PATCH] D23662: [libclang] Control whether crash recovery is enabled/disabled using function argument.

2016-08-18 Thread John Brawn via cfe-commits
john.brawn added a subscriber: john.brawn. john.brawn added a comment. > When my Java application calls clang_createIndex() with crash recovery > enabled it replaces the JVM's segfault handler with > CrashRecoverySignalHandler and now this handler gets all the segfault signals > that would