Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

The unnecessary usings are added by Visual Studio, so I would rather leave them. For example, they often provide extension methods to containers so that containers can be used with functional paradigms, and you expect to see those methods in the Intellisense window when you type "Foo.", but

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh added inline comments. Comment at: clang-tidy-vs/ClangTidy/ClangTidyPackage.cs:53 @@ +52,3 @@ +private void MenuItemCallback(object sender, EventArgs args) +{ +} Add a FIXME to actually implement this.

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added a comment. I am planning to submit this today if there are no further suggestions. https://reviews.llvm.org/D23848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added a comment. Anyone else have any thoughts on this or is this good to go? https://reviews.llvm.org/D23848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

amccarth added inline comments. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:68 @@ +67,3 @@ +return Name_; +return ParentPath + "-" + Name_; +} OK, cool. I assumed that the root had a name. Thus a node with no

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added a comment. In https://reviews.llvm.org/D23848#525485, @Eugene.Zelenko wrote: > I think will be good idea to mention this plugin in docs/ReleaseNotes.rst. I was planning to wait until it's "finished". This patch will give you a user interface for editing .clang-tidy files, but

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

Eugene.Zelenko added a comment. I think will be good idea to mention this plugin in docs/ReleaseNotes.rst. https://reviews.llvm.org/D23848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

amccarth added a comment. I don't know enough C# to review for language usage. I was mostly reading for understandability. Overall, I think this looks really nice. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:67 @@ +66,3 @@ +if (ParentPath == null) +

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh added inline comments. Comment at: clang-tidy-vs/ClangTidy/ClangTidyProperties.cs:82 @@ +81,3 @@ +public bool CERTDCL50 +{ +get { return GetInheritableProperty("CERTDCL50").Value; } zturner wrote: > alexfh wrote: > > zturner

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added inline comments. Comment at: clang-tidy-vs/ClangTidy/ClangTidyProperties.cs:82 @@ +81,3 @@ +public bool CERTDCL50 +{ +get { return GetInheritableProperty("CERTDCL50").Value; } alexfh wrote: > zturner wrote: > > Are the

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh added inline comments. Comment at: clang-tidy-vs/ClangTidy/ClangTidyProperties.cs:82 @@ +81,3 @@ +public bool CERTDCL50 +{ +get { return GetInheritableProperty("CERTDCL50").Value; } zturner wrote: > Are the .rst files in the

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added a comment. BTW, since I forgot to do so in the original review, here is a screenshot of what the UI for the property editor looks like in this extension: F2328405: clang-tidy.png Comment at:

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added inline comments. Comment at: clang-tidy-vs/ClangTidy/ClangTidyProperties.cs:82 @@ +81,3 @@ +public bool CERTDCL50 +{ +get { return GetInheritableProperty("CERTDCL50").Value; } Are the .rst files in the repo somewhere

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh added a comment. In https://reviews.llvm.org/D23848#524608, @zturner wrote: > I can fix the empty lines, but keep in mind that Visual Studio's C# editor is > MUCH more aggressive about auto-formatting your code. So it seems like a > fruitless endeavor to me, as we will constantly be

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added inline comments. Comment at: CMakeLists.txt:6 @@ -5,2 +5,3 @@ add_subdirectory(clang-tidy) +add_subdirectory(clang-tidy-vs) endif() alexfh wrote: > Should the plugin be placed inside clang-tidy directory? I followed the same way that the clang

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added a comment. I can fix the empty lines, but keep in mind that Visual Studio's C# editor is MUCH more aggressive about auto-formatting your code. So it seems like a fruitless endeavor to me, as we will constantly be fighting against their auto formatter, which does this

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:79 @@ +78,3 @@ +} + + Unnecessary empty line. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:93 @@ +92,3 @@ +{ + +}

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Awesome! A few comments. Comment at: CMakeLists.txt:6 @@ -5,2 +5,3 @@ add_subdirectory(clang-tidy) +add_subdirectory(clang-tidy-vs) endif()