Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

2016-09-13 Thread Bruno Cardoso Lopes via cfe-commits
bruno closed this revision. bruno added a comment. Thanks Doug! Committed r281383 https://reviews.llvm.org/D23852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

2016-09-12 Thread Doug Gregor via cfe-commits
doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. I don't love the fact that it makes callers fragile, but having to do tentative parsing for these otherwise-unambiguous cases is expensive (in compile time). We should only use

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

2016-09-12 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. Ping! https://reviews.llvm.org/D23852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

2016-09-06 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. Ping! In https://reviews.llvm.org/D23852#529308, @aaron.ballman wrote: > In https://reviews.llvm.org/D23852#525291, @doug.gregor wrote: > > > This will work, but it's *really* unfortunate to put tentative parsing into > > this code path because tentative parsing is far

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

2016-08-30 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment. In https://reviews.llvm.org/D23852#525291, @doug.gregor wrote: > This will work, but it's *really* unfortunate to put tentative parsing into > this code path because tentative parsing is far from free, and

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

2016-08-30 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. Ping! https://reviews.llvm.org/D23852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

2016-08-26 Thread Bruno Cardoso Lopes via cfe-commits
bruno updated the summary for this revision. bruno updated this revision to Diff 69456. bruno added a comment. Updated patch and changed approach after Doug's comment. https://reviews.llvm.org/D23852 Files: lib/Parse/ParseDecl.cpp lib/Parse/ParseObjc.cpp lib/Parse/Parser.cpp

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

2016-08-25 Thread Doug Gregor via cfe-commits
doug.gregor added a comment. This will work, but it's *really* unfortunate to put tentative parsing into this code path because tentative parsing is far from free, and specialized Objective-C types are getting pretty common in Objective-C headers. Why can't the callers be taught to handle EOF

[PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

2016-08-24 Thread Bruno Cardoso Lopes via cfe-commits
bruno created this revision. bruno added a reviewer: doug.gregor. bruno added subscribers: cfe-commits, manmanren. Fix a crash-on-invalid. When parsing type arguments and protocols, ParseTypeName() tries to find matching tokens for '[', '(', etc whenever they appear among potential type names.