Re: [PATCH] D24134: [WebAssembly] Change wasm SizeType to match asmjs

2016-09-01 Thread Derek Schuff via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280420: [WebAssembly] Change wasm SizeType to match asmjs (authored by dschuff). Changed prior to commit: https://reviews.llvm.org/D24134?vs=70008=70082#toc Repository: rL LLVM

Re: [PATCH] D24134: [WebAssembly] Change wasm SizeType to match asmjs

2016-09-01 Thread Dan Gohman via cfe-commits
sunfish added a comment. LGTM as a temporary workaround. https://reviews.llvm.org/D24134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24134: [WebAssembly] Change wasm SizeType to match asmjs

2016-09-01 Thread Derek Schuff via cfe-commits
dschuff added a comment. test comment https://reviews.llvm.org/D24134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24134: [WebAssembly] Change wasm SizeType to match asmjs

2016-09-01 Thread Jacob Gravelle via cfe-commits
jgravelle-google created this revision. jgravelle-google added a reviewer: dschuff. jgravelle-google added a subscriber: cfe-commits. Herald added subscribers: dschuff, jfb. We want wasm and asmjs to have matching ABIs, and right now asmjs uses unsigned int for its size_t. This causes exported