This revision was automatically updated to reflect the committed changes.
Closed by commit rL282136: clang-format: Add an option to git-clang-format to
diff between to commits (authored by srhines).
Changed prior to commit:
https://reviews.llvm.org/D24319?vs=72064=72138#toc
Repository:
rL
lodato accepted this revision.
lodato added a reviewer: lodato.
lodato added a comment.
This revision is now accepted and ready to land.
Nice feature. Thanks for the patch!
https://reviews.llvm.org/D24319
___
cfe-commits mailing list
lhchavez marked 9 inline comments as done.
lhchavez added a comment.
Addressed all comments. PTAAL.
https://reviews.llvm.org/D24319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lhchavez updated this revision to Diff 72064.
lhchavez added a comment.
Addressed lovato's comments
https://reviews.llvm.org/D24319
Files:
tools/clang-format/git-clang-format
Index: tools/clang-format/git-clang-format
===
---
lodato added a comment.
Could you add a note to the commit description to say that there is a backwards
incompatibility: if a filename matches a branch name or other commit-ish, then
`git clang-format ` will no longer work as expected; use `git
clang-format -- ` instead.
lodato added a comment.
Sorry for the delay - I haven't had a chance to review. I'll be sure to review
by tomorrow. Thanks for the updates!
https://reviews.llvm.org/D24319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
lhchavez added a comment.
Gentle ping. Is there anything else that needs addressing? Did I miss anything?
https://reviews.llvm.org/D24319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
