sdardis added a comment.
Ping.
https://reviews.llvm.org/D24448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vkalintiris added a subscriber: vkalintiris.
vkalintiris added a comment.
I removed myself from the reviewers because I'm not quite familiar with this
area. @joerg I added you as reviewer because you've already commented, feel
free to undo my change if you don't have time to review this.
sdardis updated this revision to Diff 71507.
sdardis added a comment.
Update comment and test for atomic expansion.
https://reviews.llvm.org/D24448
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
joerg added a comment.
More precisely, this should re-use the logic from __atomic_is_lock_free and not
reinvent it.
https://reviews.llvm.org/D24448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
joerg added a subscriber: joerg.
joerg added a comment.
While I agree with the general sentiment, the check doesn't work at all. For
example, ARMv4 always has to use libcalls. It's not even true that libcalls are
slow, i.e. on true non-parallel architectures, the libcall can be as simple as
a
sdardis created this revision.
sdardis added a subscriber: cfe-commits.
Herald added a reviewer: vkalintiris.
Herald added a subscriber: aemerson.
Targets typically support atomics that are word sized (e.g. 32 or 64 bit) or
half word sized (e.g. 32 bit on 64 bit systems). For larger sizes, some
