Re: [PATCH] D24477: clang-format: [JS] Do not wrap taze: IWYU comments

2016-09-18 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281857: clang-format: [JS] Do not wrap taze annotation comments. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D24477?vs=71189=71756#toc Repository: rL LLVM

Re: [PATCH] D24477: clang-format: [JS] Do not wrap taze: IWYU comments

2016-09-13 Thread Martin Probst via cfe-commits
mprobst marked an inline comment as done. mprobst added a comment. https://reviews.llvm.org/D24477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24477: clang-format: [JS] Do not wrap taze: IWYU comments

2016-09-13 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Generally looks good. Comment at: unittests/Format/FormatTestJS.cpp:1433 @@ +1432,3 @@ +TEST_F(FormatTestJS, ImportComments) { + verifyFormat("import {x} from 'x'; //

Re: [PATCH] D24477: clang-format: [JS] Do not wrap taze: IWYU comments

2016-09-13 Thread Martin Probst via cfe-commits
mprobst updated this revision to Diff 71189. mprobst added a comment. - update commit msg - make test case a bit more generic https://reviews.llvm.org/D24477 Files: lib/Format/Format.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp

[PATCH] D24477: clang-format: [JS] Do not wrap taze: IWYU comments

2016-09-12 Thread Martin Probst via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. See (sorry, internal link): go/taze#global-symbols-dts-externs. Before: // taze: many, different, symbols from // //some/long/iwyu/style/target