Re: [PATCH] D24512: AMDGPU: Fix target options fp32/64-denormals

2016-09-13 Thread Yaxun Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281357: AMDGPU: Fix target options fp32/64-denormals (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D24512?vs=71183=71201#toc Repository: rL LLVM

Re: [PATCH] D24512: AMDGPU: Fix target options fp32/64-denormals

2016-09-13 Thread Yaxun Liu via cfe-commits
yaxunl added inline comments. Comment at: lib/Basic/Targets.cpp:1962 @@ -1961,3 +1961,3 @@ bool hasLDEXPF:1; - bool hasDenormSupport:1; + bool hasFP32DenormSupport:1; tstellarAMD wrote: > I think this name is a little confusing, because the hardware does

Re: [PATCH] D24512: AMDGPU: Fix target options fp32/64-denormals

2016-09-13 Thread Tom Stellard via cfe-commits
tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. Once small comment otherwise. LGTM. Comment at: lib/Basic/Targets.cpp:1962 @@ -1961,3 +1961,3 @@ bool hasLDEXPF:1; - bool hasDenormSupport:1; + bool

[PATCH] D24512: AMDGPU: Fix target options fp32/64-denormals

2016-09-13 Thread Yaxun Liu via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tstellarAMD, nhaustov, arsenm. yaxunl added subscribers: cfe-commits, AMDGPU. Herald added a subscriber: wdng. Fix target options for fp32/64-denormals so that +fp64-denormals is set if fp64 is supported -fp32-denormals if fp32 denormals