This revision was automatically updated to reflect the committed changes.
Closed by commit rL281457: Supports adding insertion around non-insertion
replacements. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24515?vs=71335=71337#toc
Repository:
rL LLVM
ioeric updated this revision to Diff 71335.
ioeric added a comment.
- Updated comment.
https://reviews.llvm.org/D24515
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/RefactoringTest.cpp
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: include/clang/Tooling/Core/Replacement.h:172
@@ -169,1 +171,3 @@
+ /// - aren't both inserts at the same code location.
+ /// Note: two
ioeric updated this revision to Diff 71332.
ioeric marked an inline comment as done.
ioeric added a comment.
- Addressed comment.
https://reviews.llvm.org/D24515
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
Index:
djasper added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:172
@@ +171,3 @@
+ /// - They do not overlap.
+ /// - One replacement is insertion, and the other is a replacement with
+ /// length > 0, and the insertion is adjecent to but not
ioeric created this revision.
ioeric added reviewers: djasper, klimek.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Extend `tooling::Replacements::add()` to support adding order-independent
replacements.
Two replacements are considered order-independent if one of
