Re: [PATCH] D24642: Use __attribute__((internal_linkage)) when available.

2016-09-15 Thread Eric Fiselier via cfe-commits
EricWF added a comment. I'll commit this change tomorrow barring any objections. https://reviews.llvm.org/D24642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24642: Use __attribute__((internal_linkage)) when available.

2016-09-15 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 71590. EricWF added a comment. - Add `always_inline` to _LIBCPP_INLINE_VISIBILITY. In future I think only _LIBCPP_ALWAYS_INLINE should actually apply `always_inline`, but I'll make that change separately. - Change `_LIBCPP_ALWAYS_INLINE` to use

Re: [PATCH] D24642: Use __attribute__((internal_linkage)) when available.

2016-09-15 Thread Evgeniy Stepanov via cfe-commits
eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. Looks great. Thank you for seeing it through! https://reviews.llvm.org/D24642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24642: Use __attribute__((internal_linkage)) when available.

2016-09-15 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 71579. EricWF added a comment. Revert accidental change. https://reviews.llvm.org/D24642 Files: include/__config src/string.cpp Index: src/string.cpp === --- src/string.cpp +++

[PATCH] D24642: Use __attribute__((internal_linkage)) when available.

2016-09-15 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added reviewers: mclow.lists, eugenis. EricWF added subscribers: cfe-commits, eugenis. This patch has been a long time coming (Thanks @eugenis). It changes `_LIBCPP_INLINE_VISIBILITY` to use `__attribute__((internal_linkage))` instead of