[PATCH] D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined

2016-10-03 Thread Aleksei Sidorin via cfe-commits
a.sidorin abandoned this revision. a.sidorin added a comment. Merged into https://reviews.llvm.org/D14326 and committed. https://reviews.llvm.org/D24807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined

2016-09-22 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. Serialization tests usually come from PCH, so you could probably look in test/PCH to get ideas on how to test this. https://reviews.llvm.org/D24807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined

2016-09-22 Thread Alexey Bataev via cfe-commits
ABataev added a subscriber: ABataev. ABataev added a comment. You need to add tests for serialization/deserialization https://reviews.llvm.org/D24807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined

2016-09-21 Thread Aleksei Sidorin via cfe-commits
a.sidorin created this revision. a.sidorin added reviewers: aaron.ballman, doug.gregor. a.sidorin added a subscriber: cfe-commits. I have encountered a segfault when I tried to get sub-expression of serialized ArrayTypeTraitExpr. The fix is simple but I have no idea about nice test. Maybe you