[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

xazax.hun closed this revision. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. Thanks for the reviews, committed in https://reviews.llvm.org/rL287107 . https://reviews.llvm.org/D24894 ___ cfe-commits mailing list

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. This revision is now accepted and ready to land. Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:89 +diag(FuncInst->getLocStart(),

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:71 + +static const StringRef Message = "prefer transparent functors (%0)"; + You should quote the %0 to clarify that you're referring to syntax.

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

xazax.hun updated this revision to Diff 76860. xazax.hun marked 5 inline comments as done. xazax.hun added a comment. - Addressed review comments. https://reviews.llvm.org/D24894 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:26 + unless(hasAnyTemplateArgument(refersToType(voidType(, + hasAnyName("::std::plus", "::std::minus", "::std::multiplies", + "::std::divides",

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

Prazek added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-transparent-functors.rst:12 + .. code-block:: c++ + +// Non-transparent functor Say somewhere that you also handle cases like std::less(arg1, arg2) because from this

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

Prazek added inline comments. Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:70 +static const StringRef Message = +"prefer transparent functors (aka diamond operators)"; + The message would be much better if you would put the name of this

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

xazax.hun added a comment. I have attached the results of this checker after running it on LLVM. F2522345: results.txt https://reviews.llvm.org/D24894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

xazax.hun updated the summary for this revision. xazax.hun removed rL LLVM as the repository for this revision. xazax.hun updated this revision to Diff 75530. xazax.hun marked 3 inline comments as done. xazax.hun added a comment. - Fixed the performance problems. - Altered the diagnostic text. -

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

xazax.hun added inline comments. Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:26 + unless(hasAnyTemplateArgument(refersToType(voidType(, + hasAnyName("::std::plus", "::std::minus", "::std::multiplies", + "::std::divides",

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

aaron.ballman added inline comments. > UseTransparentFunctorsCheck.cpp:26 > + unless(hasAnyTemplateArgument(refersToType(voidType(, > + hasAnyName("::std::plus", "::std::minus", "::std::multiplies", > + "::std::divides", "::std::modulus", "::std::negate", Should we

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

xazax.hun created this revision. xazax.hun added reviewers: alexfh, hokein. xazax.hun added a subscriber: cfe-commits. xazax.hun set the repository for this revision to rL LLVM. xazax.hun added a project: clang-tools-extra. Herald added subscribers: mgorny, beanz. This check finds the usages of