This revision was automatically updated to reflect the committed changes.
Closed by commit rL282610: [CUDA] Added support for CUDA-8 (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D24946?vs=72707=72863#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24946
Files:
tra updated this revision to Diff 72707.
tra added a comment.
addressed Justin's comments.
https://reviews.llvm.org/D24946
Files:
lib/Driver/ToolChains.cpp
lib/Headers/__clang_cuda_runtime_wrapper.h
test/Driver/Inputs/CUDA/usr/local/cuda/nvvm/libdevice/libdevice.compute_20.10.bc
tra marked an inline comment as done.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:156
@@ +155,3 @@
+#endif
+#endif
+
jlebar wrote:
> I don't understand what we are doing here...
>
> We're saying, if __USE_FAST_MATH__ is defined, and if it's not equal
jlebar added inline comments.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:139
@@ -137,1 +138,3 @@
+// CUDA 8.0.41 relies on __USE_FAST_MATH__ and __CUDA_PREC_DIV's values
+// Previous versions used to check thether they are defined or not.
Nit,
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
Herald added a subscriber: jlebar.
https://reviews.llvm.org/D24946
Files:
lib/Driver/ToolChains.cpp
lib/Headers/__clang_cuda_runtime_wrapper.h
