This revision was automatically updated to reflect the committed changes.
Closed by commit rL283678: [CUDA] Declare our __device__ math functions in the
same inline namespace as… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D24977?vs=72684=74052#toc
Repository:
rL
tra added a comment.
OK.
https://reviews.llvm.org/D24977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
> That is way too much knowledge about details of standard library
> implementation.
Honestly I think this looks a lot scarier than it is. Or, to be specific, I
think we are already relying on implementation details much more implicit and
fragile than what is
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
That is way too much knowledge about details of standard library implementation.
If it changes, I suspect users will end up with a rather uninformative error.
Is there a way to produce somewhat more
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: jhen, cfe-commits.
Currently we declare our inline __device__ math functions in namespace
std. But libstdc++ and libc++ declare these functions in an inline
namespace inside namespace std. We need to match