Re: [PATCH] D24981: [Coverage] The coverage region for a switch should cover the code after the switch

2016-09-27 Thread Alex Lorenz via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282554: [Coverage] The coverage region for switch covers the code after the switch. (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D24981?vs=72692=72733#toc Repository: rL

Re: [PATCH] D24981: [Coverage] The coverage region for a switch should cover the code after the switch

2016-09-27 Thread Vedant Kumar via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM, thank you! It makes sense to inherit the current region's counter when we see a new switch. That should fix the 0 execution count we see on the condition. Repository: rL LLVM

[PATCH] D24981: [Coverage] The coverage region for a switch should cover the code after the switch

2016-09-27 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added a reviewer: vsk. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch fixes a regression introduced in r262697 that changed the way the coverage regions for switch are constructed. The PGO