This revision was automatically updated to reflect the committed changes.
Closed by commit rL296732: [libc++] Make _LIBCPP_TYPE_VIS export members
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D25208?vs=90275&id=90276#toc
Repository:
rL LLVM
https://reviews.llvm.o
smeenai updated this revision to Diff 90275.
smeenai added a comment.
Rebase
https://reviews.llvm.org/D25208
Files:
docs/DesignDocs/VisibilityMacros.rst
include/__config
include/__locale
include/__mutex_base
include/condition_variable
include/future
include/mutex
include/shared_
smeenai updated this revision to Diff 90109.
smeenai added a comment.
Rebase atop https://reviews.llvm.org/D29157 and switch to
_LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS
https://reviews.llvm.org/D25208
Files:
docs/DesignDocs/VisibilityMacros.rst
include/__config
include/__locale
smeenai updated this revision to Diff 87911.
smeenai added a comment.
Rebase and ping
https://reviews.llvm.org/D25208
Files:
docs/DesignDocs/VisibilityMacros.rst
include/__config
include/__locale
include/__mutex_base
include/condition_variable
include/future
include/mutex
includ
smeenai added a comment.
Ping.
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai updated this revision to Diff 85816.
smeenai edited the summary of this revision.
smeenai removed a reviewer: compnerd.
smeenai added a comment.
Folding https://reviews.llvm.org/D27430 and addressing comments from that diff.
https://reviews.llvm.org/D25208
Files:
docs/DesignDocs/Visib
smeenai added a comment.
In https://reviews.llvm.org/D25208#647743, @EricWF wrote:
> Actually I probably shouldn't have approved this due to
> http://llvm.org/PR30642. I forgot about that when I last reviewed this.
Yup. I wrote https://github.com/smeenai/bad-visibility-finder to find all
prob
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
Actually I probably shouldn't have approved this due to
http://llvm.org/PR30642. I forgot about that when I last reviewed this.
https://reviews.llvm.org/D25208
__
EricWF added a comment.
Yeah, that sounds good. I want to do more investigation into this as well.
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Not gonna submit this till https://reviews.llvm.org/D27430 has been submitted
(will address comments on that one after holidays).
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
smeenai requested a review of this revision.
smeenai added a comment.
Actually, I think this can stand on its own. I'll do the extern template fixes
in another diff.
Also, ping :)
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-co
smeenai planned changes to this revision.
smeenai added a comment.
Hidden visibility also requires extern template declarations to expand to
default visibility (as opposed to just default type visibility) to be feasible.
Will fix annotations there and then roll that macro change into this diff.
smeenai added a comment.
https://reviews.llvm.org/D27430 should unblock this.
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai updated this revision to Diff 80334.
smeenai added a comment.
Rebasing
https://reviews.llvm.org/D25208
Files:
docs/DesignDocs/VisibilityMacros.rst
include/__config
Index: include/__config
===
--- include/__config
+++
smeenai added a comment.
I should clarify that the ABI omissions are for Linux.
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Ping.
I used @EricWF's ABI list verification work to confirm that this diff doesn't
change the ABI of libc++ on both Darwin and Linux, so it should be completely
safe.
Building with hidden visibility on top of this patch gives the following ABI
removals: https://revie
smeenai added a comment.
Ping :)
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Ping.
The way I see it, this doesn't change anything for people not building with
hidden visibility (which should be most people, including the buildbots), but
it does make `_LIBCPP_TYPE_VIS` more useful (and consistent with the existing
Windows behavior) for people bu
smeenai added a comment.
In https://reviews.llvm.org/D25208#564930, @EricWF wrote:
> Why do you want to build `libc++.so` with hidden visibility? What's wrong
> with the existing way we build `libc++.so`?
There's nothing wrong with the existing way, per se. I personally prefer hidden
visibil
EricWF added a comment.
Why do you want to build `libc++.so` with hidden visibility? What's wrong with
the existing way we build `libc++.so`?
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Most classes annotated with _LIBCPP_TYPE_VIS need to have at least some
of their members exported, otherwise we have a lot of link errors when
linking against a libc++ bu
21 matches
Mail list logo
