This revision was automatically updated to reflect the committed changes.
arphaman marked an inline comment as done.
Closed by commit rL292497: [Sema] Fix PR28181 by avoiding calling
BuildOverloadedBinOp in C mode (authored by arphaman).
Changed prior to commit:
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: lib/Sema/SemaExpr.cpp:11523
// being assigned to.
if (Opc == BO_Assign && pty->getKind() == BuiltinType::Overload) {
+ if
arphaman added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D25213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman updated this revision to Diff 83822.
arphaman added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D25213
Files:
lib/Sema/SemaExpr.cpp
test/Sema/PR28181.c
Index: test/Sema/PR28181.c
===
---
arphaman updated this revision to Diff 73460.
arphaman marked an inline comment as done.
arphaman added a comment.
Thanks for the response,
I updated the patch with a approach that you suggested - now
`Sema::CreateOverloadedBinOp` isn't called in C mode (I have an assertion for
this in
rsmith added inline comments.
> SemaOverload.cpp:11750
> ExprResult
> Sema::CreateOverloadedBinOp(SourceLocation OpLoc,
> BinaryOperatorKind Opc,
We should never be calling this function outside of C++ mode.
It looks like the bug is in `Sema::BuildBinOp` -- in C,
arphaman created this revision.
arphaman added reviewers: rsmith, rjmccall.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a crash that happens because of an assertion failure in C mode
only. The assertion failure happens