[PATCH] D25519: [CodeCompletion] Refactor: Extract two Objective-C block formatting related functions from FormatFunctionParameter

2016-10-18 Thread Alex Lorenz via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284467: [CodeCompletion][NFC] Extract a function that looks for block decl type locs. (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25519?vs=74520&id=74972#toc Repository:

[PATCH] D25519: [CodeCompletion] Refactor: Extract two Objective-C block formatting related functions from FormatFunctionParameter

2016-10-14 Thread Manman Ren via cfe-commits
manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman Repository: rL LLVM https://reviews.llvm.org/D25519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D25519: [CodeCompletion] Refactor: Extract two Objective-C block formatting related functions from FormatFunctionParameter

2016-10-13 Thread Alex Lorenz via cfe-commits
arphaman updated this revision to Diff 74520. arphaman marked 2 inline comments as done. arphaman added a comment. The updated patch has comments for the two extracted functions. Repository: rL LLVM https://reviews.llvm.org/D25519 Files: lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaC

[PATCH] D25519: [CodeCompletion] Refactor: Extract two Objective-C block formatting related functions from FormatFunctionParameter

2016-10-12 Thread Manman Ren via cfe-commits
manmanren added a comment. Cheers, Manman Comment at: lib/Sema/SemaCodeComplete.cpp:2165 +static void findTypeLocationForBlockDecl(const TypeSourceInfo *TSInfo, + FunctionTypeLoc &Block, Please add comments for the help

[PATCH] D25519: [CodeCompletion] Refactor: Extract two Objective-C block formatting related functions from FormatFunctionParameter

2016-10-12 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added a reviewer: manmanren. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch extracts two new functions from the function `FormatFunctionParameter` that are related to Objective-C block formatt