[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

2016-10-25 Thread Bob Haarman via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285132: [codeview] emit debug info for indirect virtual base classes (authored by inglorion). Changed prior to commit: https://reviews.llvm.org/D25579?vs=75381=75804#toc Repository: rL LLVM

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

2016-10-21 Thread Bob Haarman via cfe-commits
inglorion added a comment. We also need https://reviews.llvm.org/D25578 in before this can land. https://reviews.llvm.org/D25579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

2016-10-20 Thread Bob Haarman via cfe-commits
inglorion updated this revision to Diff 75381. inglorion added a comment. Use insert's return value to save a set lookup, and use CanonicalDeclPtr https://reviews.llvm.org/D25579 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-ms-vbase.cpp Index:

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

2016-10-20 Thread Bob Haarman via cfe-commits
inglorion updated this revision to Diff 75367. inglorion added a comment. Updated to track the latest state of https://reviews.llvm.org/D25578 https://reviews.llvm.org/D25579 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-ms-vbase.cpp Index:

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

2016-10-19 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks, looks good with some nits Comment at: lib/CodeGen/CGDebugInfo.cpp:1397 const auto *Base = cast(BI.getType()->getAs()->getDecl()); rnk

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

2016-10-14 Thread Bob Haarman via cfe-commits
inglorion updated this revision to Diff 74734. inglorion added a comment. - Removed unused header. https://reviews.llvm.org/D25579 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-ms-vbase.cpp Index: test/CodeGenCXX/debug-info-ms-vbase.cpp

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

2016-10-14 Thread Bob Haarman via cfe-commits
inglorion updated this revision to Diff 74733. inglorion added a comment. @rnk's comments (thanks!) - Converted SeenTypes to a DenseSet. - Switched to getCodeGenOpts().EmitCodeView to check if we should emit the extra records. - Switched to using SeenTypes.count(...) != 0 to check if we've seen

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

2016-10-13 Thread David Majnemer via cfe-commits
majnemer added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1392 +auto *BaseTy = getOrCreateType(BI.getType(), Unit); +if (SeenTypes.find(BaseTy) != SeenTypes.end()) + continue; ruiu wrote: > zturner wrote: > > rnk wrote: > > > IMO

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

2016-10-13 Thread Rui Ueyama via cfe-commits
ruiu added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1392 +auto *BaseTy = getOrCreateType(BI.getType(), Unit); +if (SeenTypes.find(BaseTy) != SeenTypes.end()) + continue; zturner wrote: > rnk wrote: > > IMO `SeenTypes.count(...)`