[PATCH] D25764: Add end location of loop to loop metadata.

2016-11-10 Thread Amara Emerson via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286456: Add the loop end location to the loop metadata. This additional information (authored by aemerson). Changed prior to commit: https://reviews.llvm.org/D25764?vs=77317&id=77478#toc Repository:

[PATCH] D25764: Add end location of loop to loop metadata.

2016-11-09 Thread John McCall via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Looks good, thanks! https://reviews.llvm.org/D25764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D25764: Add end location of loop to loop metadata.

2016-11-09 Thread Florian Hahn via cfe-commits
fhahn added a comment. @rjmccall thanks for the feedback. I initially kept the arguments optional because the single Location argument used to be optional as well. But I think we can pass proper locations for all loops constructed by clang and I updated my patch to make the Start and End locati

[PATCH] D25764: Add end location of loop to loop metadata.

2016-11-09 Thread Florian Hahn via cfe-commits
fhahn updated this revision to Diff 77317. https://reviews.llvm.org/D25764 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGLoopInfo.cpp lib/CodeGen/CGLoopInfo.h lib/CodeGen/CGStmt.cpp lib/CodeGen/CGStmtOpenMP.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeG

[PATCH] D25764: Add end location of loop to loop metadata.

2016-11-08 Thread Florian Hahn via cfe-commits
fhahn added a comment. Ping. It would be great if somebody could have a look at this patch. The companion LLVM patch https://reviews.llvm.org/D25763 (https://reviews.llvm.org/D25763) has been accepted already. https://reviews.llvm.org/D25764 ___

[PATCH] D25764: Add end location of loop to loop metadata.

2016-11-07 Thread John McCall via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D25764#588752, @hfinkel wrote: > This makes sense to me; @anemet , @rjmccall , any thoughts? Why are the constructor arguments optional? Are there actually any loops that we push that lack start and end locs? https://reviews.llvm.org/D2

[PATCH] D25764: Add end location of loop to loop metadata.

2016-11-07 Thread Hal Finkel via cfe-commits
hfinkel added a comment. This makes sense to me; @anemet , @rjmccall , any thoughts? https://reviews.llvm.org/D25764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25764: Add end location of loop to loop metadata.

2016-10-19 Thread Florian Hahn via cfe-commits
fhahn created this revision. fhahn added a reviewer: hfinkel. fhahn added a subscriber: cfe-commits. The patch adds the loop end location to the loop metadata. This additional information can be used to improve the locations when generating remarks for loops. The patch depends on the companion