[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

This revision was automatically updated to reflect the committed changes. Closed by commit rL292615: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25817?vs=75712=85135#toc Repository:

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

arphaman added a comment. Are there any other comments for this patch? I would like to commit it in the next couple of days, as it was accepted and I believe I addressed Richard's concerns. Thanks Repository: rL LLVM https://reviews.llvm.org/D25817

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

arphaman updated this revision to Diff 75712. arphaman added a comment. The updated patch addresses Richard's comment by making sure the fixit isn't emitted when the destructor call is invalid. Repository: rL LLVM https://reviews.llvm.org/D25817 Files: lib/Sema/SemaExprCXX.cpp

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

rsmith added a comment. In https://reviews.llvm.org/D25817#576276, @arphaman wrote: > This code does perform recovery, but the constructed AST for the destructor > calls is different from the AST that would have been constructed if the code > was correct: we still end up building the pseudo

Re: [PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

On Fri, Oct 21, 2016 at 3:16 AM Alex Lorenz wrote: > arphaman updated this revision to Diff 75403. > arphaman added a comment. > > The updated patch improves error handling and adds a test for the fixit. > > > If we issue a fixit we should recover as-if the code was written

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

arphaman updated this revision to Diff 75405. arphaman added a comment. Fix a typo in the fixit test. Repository: rL LLVM https://reviews.llvm.org/D25817 Files: lib/Sema/SemaExprCXX.cpp test/CXX/special/class.dtor/p10-0x.cpp test/FixIt/fixit.cpp test/SemaCXX/pseudo-destructors.cpp

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

arphaman updated this revision to Diff 75403. arphaman added a comment. The updated patch improves error handling and adds a test for the fixit. > If we issue a fixit we should recover as-if the code was written with the > fixit in. Does this code do that? (can we test it? I know we test some

Re: [PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

On Thu, Oct 20, 2016 at 11:02 AM, David Blaikie wrote: > If we issue a fixit we should recover as-if the code was written with the > fixit in. Does this code do that? That's a good point; I don't think this patch does the fix. > (can we test it? I know we test some > fixits

Re: [PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

If we issue a fixit we should recover as-if the code was written with the fixit in. Does this code do that? (can we test it? I know we test some fixits - not sure it's necessary/worthwhile to test them all, but maybe we have a good idiom for testing that the recovery is correct) On Thu, Oct 20,

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

arphaman created this revision. arphaman added reviewers: dblaikie, majnemer. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch improves the mismatched destructor type error by detecting when the destructor call has used a '.' instead