[PATCH] D26150: [libc++abi] Fix test_exception_storage_nodynmem on MacOS

2016-11-09 Thread Shoaib Meenai via cfe-commits
smeenai abandoned this revision. smeenai added a comment. Abandoning this then. In case the new incarnation of the test needs to overwrite any memory allocation methods, this diff has the most reliable way to do it on OS X :) https://reviews.llvm.org/D26150

[PATCH] D26150: [libc++abi] Fix test_exception_storage_nodynmem on MacOS

2016-11-08 Thread Igor Kudrin via cfe-commits
ikudrin added a comment. The test is too implementation-specific, and trying to override a function like `calloc` makes it fragile. Unfortunately, I didn't find a better way to test the library's behavior in case of memory exhaustion, but now I believe that this test doesn't add any

[PATCH] D26150: [libc++abi] Fix test_exception_storage_nodynmem on MacOS

2016-11-07 Thread Shoaib Meenai via cfe-commits
smeenai added a comment. In https://reviews.llvm.org/D26150#587973, @ikudrin wrote: > This test is extremely fragile. Maybe, it is better to disable it, or even > delete it altogether. I'll take your word for it, as the original author of the test, though I'm curious about where the

[PATCH] D26150: [libc++abi] Fix test_exception_storage_nodynmem on MacOS

2016-10-31 Thread Shoaib Meenai via cfe-commits
smeenai created this revision. smeenai added reviewers: compnerd, EricWF, howard.hinnant, ikudrin, mclow.lists. smeenai added a subscriber: cfe-commits. Mach-O defaults to two-level namespaces, so `calloc` cannot be interpositoned. Override it via the default malloc zone instead. Note: