nkakuev marked an inline comment as done.
nkakuev added inline comments.
Comment at: test/clang-tidy/nolint.cpp:36
+}
+// CHECK-NOT: trigger_warning.h:{{.*}} warning: The left operand of '>' is a
garbage value
+// CHECK-NOT: :[[@LINE-4]]:{{.*}} note
alexfh
nkakuev added a comment.
@alexfh I'll fix it in a separate review.
https://reviews.llvm.org/D26218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: test/clang-tidy/nolint.cpp:36
+}
+// CHECK-NOT: trigger_warning.h:{{.*}} warning: The left operand of '>' is a
garbage value
+// CHECK-NOT: :[[@LINE-4]]:{{.*}} note
The test is too brittle: if the functionality breaks
malcolm.parsons closed this revision.
malcolm.parsons added a comment.
Committed as r285861.
Thanks!
https://reviews.llvm.org/D26218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nkakuev added a comment.
@malcolm.parsons, can you please commit this patch? I don't have commit rights.
https://reviews.llvm.org/D26218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nkakuev updated this revision to Diff 76769.
nkakuev marked an inline comment as done.
nkakuev added a comment.
Fix a typo.
https://reviews.llvm.org/D26218
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
malcolm.parsons accepted this revision.
malcolm.parsons added a comment.
This revision is now accepted and ready to land.
LGTM, with typo below fixed.
Comment at: test/clang-tidy/nolint.cpp:36
+}
+// CHECK-NOT: header.h:{{.*}} warning: The left operand of '>' is a garbage
nkakuev added a reviewer: malcolm.parsons.
nkakuev updated this revision to Diff 76718.
nkakuev added a comment.
Fixed review comments: replaced a static variable with a class member.
https://reviews.llvm.org/D26218
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
malcolm.parsons added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:312
DiagnosticsEngine::Level DiagLevel, const Diagnostic ) {
+ static bool ShouldIgnoreNotes = false;
+ if (ShouldIgnoreNotes && DiagLevel == DiagnosticsEngine::Note)
