[PATCH] D26342: [analyzer] Add MutexChecker for the Magenta kernel

2016-11-09 Thread Artem Dergachev via cfe-commits
NoQ added a comment. In https://reviews.llvm.org/D26342#590881, @khazem wrote: > I think that it's sensible to try merging this with PthreadLockChecker. In > fact, I could also try merging the SpinLockChecker [1] that I've posted for > review with PthreadLockChecker also, since they all

[PATCH] D26342: [analyzer] Add MutexChecker for the Magenta kernel

2016-11-09 Thread Kareem Khazem via cfe-commits
khazem added a comment. Thanks for the detailed review Artem! I think that it's sensible to try merging this with PthreadLockChecker. In fact, I could also try merging the SpinLockChecker [1] that I've posted for review with PthreadLockChecker also, since they all implement similar

[PATCH] D26342: [analyzer] Add MutexChecker for the Magenta kernel

2016-11-07 Thread Artem Dergachev via cfe-commits
NoQ added a comment. It's great to see more domain-specific checks coming in! We're glad to be useful. The code is also well-commented, and a lot of tests are provided, which is great. This checker seems to be relatively similar to the existing `alpha.unix.PthreadLock` checker (which also