rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D26464
___
cfe-commits mailing list
iid_iunknown added a comment.
In https://reviews.llvm.org/D26464#594228, @rengolin wrote:
> Looks like an oversight. Aren't there any tests for this? Maybe there should
> be one.
Thanks Renato!
I updated the tests to check the upper bounds for CRn/CRm/Op.
Repository:
rL LLVM
iid_iunknown updated this revision to Diff 78021.
iid_iunknown added a comment.
Tests extended to check for more corner cases.
Repository:
rL LLVM
https://reviews.llvm.org/D26464
Files:
lib/Sema/SemaChecking.cpp
test/Sema/aarch64-special-register.c
test/Sema/arm-special-register.c
iid_iunknown updated this revision to Diff 78019.
iid_iunknown added a comment.
Tests added.
Repository:
rL LLVM
https://reviews.llvm.org/D26464
Files:
lib/Sema/SemaChecking.cpp
test/Sema/aarch64-special-register.c
test/Sema/arm-special-register.c
Index:
rengolin added a comment.
Looks like an oversight. Aren't there any tests for this? Maybe there should be
one.
Repository:
rL LLVM
https://reviews.llvm.org/D26464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org