[PATCH] D26588: Add LocationContext to members of check::RegionChanges

NoQ commandeered this revision. NoQ added a reviewer: k-wisniewski. NoQ added a comment. Seems to become outdated with https://reviews.llvm.org/D27090. https://reviews.llvm.org/D26588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/Checker.h:325 + const CallEvent *Call, + const LocationContext *LCtx) { +return ((const CHECKER *) checker)->checkRegionChanges(state, invalidated,

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

zaks.anna added inline comments. Comment at: include/clang/StaticAnalyzer/Core/Checker.h:325 + const CallEvent *Call, + const LocationContext *LCtx) { +return ((const CHECKER *) checker)->checkRegionChanges(state, invalidated,

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/Checker.h:325 + const CallEvent *Call, + const LocationContext *LCtx) { +return ((const CHECKER *) checker)->checkRegionChanges(state, invalidated,

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

zaks.anna added inline comments. Comment at: include/clang/StaticAnalyzer/Core/Checker.h:325 + const CallEvent *Call, + const LocationContext *LCtx) { +return ((const CHECKER *) checker)->checkRegionChanges(state, invalidated,

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

k-wisniewski added a comment. Hi again! Thanks for review! I'll upload updated version of this patch today in the evening/tomorrow. As Anna suggested I'll split it into two parts - one regarding extraction of argument SVals for StackFrameCtx and another one adding LocationContext to

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/Checker.h:325 + const CallEvent *Call, + const LocationContext *LCtx) { +return ((const CHECKER *) checker)->checkRegionChanges(state, invalidated,

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

zaks.anna added a comment. Hi and welcome to the project! This patch definitely looks quite complex for a first contribution, so great job at digging through the analyzer internals! One higher level comment I have is that you should try and split patches whenever possible. For example, in the

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:735 + const FunctionDecl *FunctionDecl = SFC->getDecl()->getAsFunction(); + unsigned NumArgs = FunctionDecl->getNumParams(); + assert(ArgIdx < NumArgs && "Arg access out of

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

NoQ added a comment. Welcome to phabricator! I agree that having the location context in this callback is useful, and i'm all for reducing boilerplate in various checkers through better API. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:231

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

a.sidorin added a comment. Hi Krzysztof! This change seems useful: I can imagine the situation where we want to ask current `LocationContext` in this callback. The change looks pretty intrusive but I mostly agree with it. Initially, I have some questions about the implementation of

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

k-wisniewski created this revision. k-wisniewski added reviewers: dergachev.a, dcoughlin, zaks.anna. k-wisniewski added a subscriber: cfe-commits. Hi, I've been working on a checker that uses RegionChanges interface and needed to access to LocationContext. Another change is an easy way to