This revision was automatically updated to reflect the committed changes.
Closed by commit rL289511: [analyzer] Run clang-format and fix style (authored
by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D26691?vs=80128&id=81170#toc
Repository:
rL LLVM
https://reviews.llvm.org/D266
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thank you!
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459
// Notice that the lower bound is greater than the upper bound.
- RangeSet New = GetRa
ddcc added inline comments.
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459
// Notice that the lower bound is greater than the upper bound.
- RangeSet New = GetRange(St, Sym).Intersect(getBasicVals(), F, Upper, Lower);
+ RangeSet New = getRange(St, Sym).In
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459
// Notice that the lower bound is greater than the upper bound.
- RangeSet New = GetRange(St, Sym).Intersect(getBasicVals(), F, Upper, Lower);
+ RangeSet New = getRange(St, Sy
ddcc added inline comments.
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459
// Notice that the lower bound is greater than the upper bound.
- RangeSet New = GetRange(St, Sym).Intersect(getBasicVals(), F, Upper, Lower);
+ RangeSet New = getRange(St, Sym).In
ddcc updated this revision to Diff 80128.
ddcc added a comment.
Un-change comments, misc. changes
https://reviews.llvm.org/D26691
Files:
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp
lib/StaticAnalyzer/Core/SimpleConstraintManager.h
dcoughlin added a comment.
In https://reviews.llvm.org/D26691#610292, @zaks.anna wrote:
> I am not a big fan of loosing svn blame only to fix formatting, but since you
> are modifying this code anyway, it's fine by me.
>
> Artem and Devin, what is your opinion on this?
I agree that in general
zaks.anna added a comment.
I am not a big fan of loosing svn blame only to fix formatting, but since you
are modifying this code anyway, it's fine by me.
Artem and Devin, what is your opinion on this?
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459
// No
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.
Split out formatting and style changes from https://reviews.llvm.org/D26061
https://reviews.llvm.org/D26691
Files:
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
lib/StaticAnaly
