This revision was automatically updated to reflect the committed changes.
Closed by commit rL287228: [include-fixer] Refactor include fixer to be usable
as a plugin (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D26752?vs=78354=78366#toc
Repository:
rL LLVM
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D26752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bkramer added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:136
+
+auto Begin = StartOfFile.getLocWithOffset(Placed.getOffset());
+auto End = Begin.getLocWithOffset(Placed.getLength());
ioeric wrote:
> hokein wrote:
> > ioeric wrote:
> > >
bkramer updated this revision to Diff 78354.
bkramer added a comment.
- Turn loop into an assertions, there should never be more than one replacement
coming back.
https://reviews.llvm.org/D26752
Files:
include-fixer/CMakeLists.txt
include-fixer/IncludeFixer.cpp
ioeric added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:136
+
+auto Begin = StartOfFile.getLocWithOffset(Placed.getOffset());
+auto End = Begin.getLocWithOffset(Placed.getLength());
hokein wrote:
> ioeric wrote:
> > bkramer wrote:
> > >
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:136
+
+auto Begin = StartOfFile.getLocWithOffset(Placed.getOffset());
+auto End = Begin.getLocWithOffset(Placed.getLength());
ioeric wrote:
> bkramer wrote:
> > hokein wrote:
> > >
ioeric added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:136
+
+auto Begin = StartOfFile.getLocWithOffset(Placed.getOffset());
+auto End = Begin.getLocWithOffset(Placed.getLength());
bkramer wrote:
> hokein wrote:
> > I have a concern
bkramer added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:136
+
+auto Begin = StartOfFile.getLocWithOffset(Placed.getOffset());
+auto End = Begin.getLocWithOffset(Placed.getLength());
hokein wrote:
> I have a concern that `Placed` here
bkramer updated this revision to Diff 78345.
bkramer marked 7 inline comments as done.
bkramer added a comment.
- Address review comments.
https://reviews.llvm.org/D26752
Files:
include-fixer/CMakeLists.txt
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:64
getIncludeFixerContext(const clang::SourceManager ,
clang::HeaderSearch ) {
+return SemaSource.getIncludeFixerContext(SourceManager, HeaderSearch);
also
bkramer created this revision.
bkramer added reviewers: klimek, hokein, ioeric.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
- Refactor the external sema source into a visible class
- Add support for emitting FixIts
- Wrap up include fixer as a plugin as I did with
11 matches
Mail list logo
