Re: [PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

On Wed, Dec 21, 2016 at 11:47 AM, Reid Kleckner wrote: > On Wed, Dec 21, 2016 at 8:36 AM, Aaron Ballman > wrote: >> >> That change appears to have been lost, and I would like to see them >> brought back. I think they may have gotten lost during the

Re: [PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

On Wed, Dec 21, 2016 at 8:36 AM, Aaron Ballman wrote: > That change appears to have been lost, and I would like to see them > brought back. I think they may have gotten lost during the rebase, as > they were present in https://reviews.llvm.org/D26846?id=78569. > I

Re: [PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

On Tue, Dec 20, 2016 at 5:58 PM, Kevin Puetz via Phabricator wrote: > puetzk added a comment. > > I see that you added a FIXME mentioning that it should be C++-only, but I > don't see where you actually did anything that would make it so. What am I > missing? You

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

puetzk added a comment. I see that you added a FIXME mentioning that it should be C++-only, but I don't see where you actually did anything that would make it so. What am I missing? Also, did you mean to drop the changes to utils/TableGen/ClangAttrEmitter.cpp and bring back the WarnDiag,

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

This revision was automatically updated to reflect the committed changes. Closed by commit rL289567: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D26846?vs=78569=81258#toc Repository: rL LLVM

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

rnk added a comment. FYI I had to make a few changes so that we still error out on __uuid in C mode. Repository: rL LLVM https://reviews.llvm.org/D26846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. This looks good to me, I'll merge this today unless I hear otherwise. Repository: rL LLVM https://reviews.llvm.org/D26846 ___ cfe-commits mailing

Re: [PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

I'll need a few days. I am on vacation until the 15th and have limited Internet access. I can do post commit review if this can't wait that long. -Aaron On Dec 7, 2016 9:07 PM, "David Majnemer via Phabricator" < revi...@reviews.llvm.org> wrote: majnemer added a comment. This LGTM but Aaron

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

majnemer added a comment. This LGTM but Aaron should give the go ahead. Repository: rL LLVM https://reviews.llvm.org/D26846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

puetzk added a comment. Also rebased against r287335/496a3f56c7 Repository: rL LLVM https://reviews.llvm.org/D26846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1621 let Args = [StringArgument<"Guid">]; -// let Subjects = SubjectList<[CXXRecord]>; + let Subjects = SubjectList<[CXXRecord, Enum], WarnDiag,

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

majnemer added a comment. Do we have a testcase where the declspec is applied to something inappropriate like an int? Comment at: lib/Sema/SemaDeclAttr.cpp:4669-4673 + if (!(isa(D) || isa(D))) { S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) - <<

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

puetzk created this revision. puetzk added a subscriber: cfe-commits. puetzk set the repository for this revision to rL LLVM. Although not specifically mentioned in the documentation, MSVC accepts __uuidof(…) and declspec(uuid("…")) attributes on enumeration types in addition to