This revision was automatically updated to reflect the committed changes.
Closed by commit rL368878: [Sema][ObjC] Fix a -Wformat false positive with
localizedStringForKey (authored by epilk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D27165?vs=214977&id=215150#toc
Reposi
aaron.ballman accepted this revision.
aaron.ballman added a comment.
I like this approach much better! LGTM, aside from a minor nit.
Comment at: clang/include/clang/Basic/IdentifierTable.h:754
+ /// If this selector is the specific keyword selector described by Names.
+ bool
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
One minor request (which will be dead code in your patch), but otherwise LGTM.
Comment at: clang/include/clang/Basic/IdentifierTable.h:754
+ /// If this selector is the
erik.pilkington updated this revision to Diff 214977.
erik.pilkington added a comment.
Address review comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D27165/new/
https://reviews.llvm.org/D27165
Files:
clang/include/clang/AST/FormatString.h
clang/include/clang/Basic/Identifie
rjmccall added a comment.
I agree with just special-casing this for now.
Comment at: clang/lib/Sema/SemaChecking.cpp:6800
+MD->getSelector() ==
+S.NSAPIObj->getLocalizedStringForKeySelector()) {
+ IgnoreStringsWithoutSpecifiers = true;
-
erik.pilkington updated this revision to Diff 214925.
erik.pilkington added a comment.
Special case localizedStringForKey instead of using an attribute.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D27165/new/
https://reviews.llvm.org/D27165
Files:
clang/include/clang/AST/FormatStrin
erik.pilkington commandeered this revision.
erik.pilkington added a reviewer: arphaman.
erik.pilkington added a comment.
Herald added subscribers: dexonsmith, jkorous.
Herald added a project: LLVM.
Stealing this (with Alex's permission). I think it makes more sense to add a
special case for the m
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:862
+def FormatDynamicKeyArg : InheritableAttr {
+ let Spellings = [GCC<"format_dynamic_key_arg">];
+ let Args = [IntArgument<"FormatIdx">];
arphaman wrote:
> aaron.ballman wrote:
> >
arphaman updated this revision to Diff 81952.
arphaman added a comment.
Update to fix a test failure.
Repository:
rL LLVM
https://reviews.llvm.org/D27165
Files:
include/clang/Analysis/Analyses/FormatString.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/Analysis/Pri
arphaman added inline comments.
Comment at: include/clang/Basic/Attr.td:862
+def FormatDynamicKeyArg : InheritableAttr {
+ let Spellings = [GCC<"format_dynamic_key_arg">];
+ let Args = [IntArgument<"FormatIdx">];
aaron.ballman wrote:
> Does GCC support this att
arphaman updated this revision to Diff 81950.
arphaman marked an inline comment as done.
arphaman added a comment.
The updated patch renames the attribute to
`loads_format_specifier_value_using_key` and addresses Aaron's comments
Repository:
rL LLVM
https://reviews.llvm.org/D27165
Files:
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:862
+def FormatDynamicKeyArg : InheritableAttr {
+ let Spellings = [GCC<"format_dynamic_key_arg">];
+ let Args = [IntArgument<"FormatIdx">];
Does GCC support this attribute as well? If
arphaman added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D27165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman created this revision.
arphaman added reviewers: aaron.ballman, manmanren.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch adds a new ``format_dynamic_key_arg``. It's intended to be used
instead of ``format_arg`` for methods/
14 matches
Mail list logo