[PATCH] D27204: [libcxxabi] Introduce an externally threaded libc++abi variant

2016-12-08 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath abandoned this revision. rmaprath added a comment. Abandoning as this has been replaced with https://reviews.llvm.org/D27575. https://reviews.llvm.org/D27204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27204: [libcxxabi] Introduce an externally threaded libc++abi variant

2016-12-05 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath added a comment. In https://reviews.llvm.org/D27204#613177, @EricWF wrote: > In https://reviews.llvm.org/D27204#613172, @rmaprath wrote: > > > In https://reviews.llvm.org/D27204#613122, @EricWF wrote: > > > > > My main issue with this patch (and https://reviews.llvm.org/D27206) is > >

[PATCH] D27204: [libcxxabi] Introduce an externally threaded libc++abi variant

2016-12-05 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. In https://reviews.llvm.org/D27204#613172, @rmaprath wrote: > In https://reviews.llvm.org/D27204#613122, @EricWF wrote: > > > My main issue with this patch (and https://reviews.llvm.org/D27206) is that > > there are now two different CMake options for building two

[PATCH] D27204: [libcxxabi] Introduce an externally threaded libc++abi variant

2016-12-05 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath added a comment. In https://reviews.llvm.org/D27204#613122, @EricWF wrote: > My main issue with this patch (and https://reviews.llvm.org/D27206) is that > there are now two different CMake options for building two different external > threading libraries. I would much prefer having

[PATCH] D27204: [libcxxabi] Introduce an externally threaded libc++abi variant

2016-12-05 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. My main issue with this patch (and https://reviews.llvm.org/D27206) is that there are now two different CMake options for building two different external threading libraries. I would much prefer having libc++abi use libc++'s `__threading_support` header and

[PATCH] D27204: [libcxxabi] Introduce an externally threaded libc++abi variant

2016-11-29 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath created this revision. rmaprath added reviewers: mclow.lists, EricWF, bcraig. rmaprath added a subscriber: cfe-commits. Herald added a subscriber: mgorny. This is more-or-less a mirror image of https://reviews.llvm.org/D21968, repeated for libcxxabi. I will soon upload a dependent