[PATCH] D27226: [MS ABI] Implement more of the Itanium mangling rules

This revision was automatically updated to reflect the committed changes. Closed by commit rL288826: [MS ABI] Implement more of the Itanium mangling rules (authored by majnemer). Changed prior to commit: https://reviews.llvm.org/D27226?vs=80096&id=80437#toc Repository: rL LLVM https://revie

[PATCH] D27226: [MS ABI] Implement more of the Itanium mangling rules

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Thanks, apologies for the scope creep. https://reviews.llvm.org/D27226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D27226: [MS ABI] Implement more of the Itanium mangling rules

majnemer updated this revision to Diff 80096. majnemer added a comment. - Simplify the mangling a little bit https://reviews.llvm.org/D27226 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenCXX/mangle-ms-cxx11.cpp Index: test/CodeGenCXX/mangle-ms-cxx11.cpp ===

[PATCH] D27226: [MS ABI] Implement more of the Itanium mangling rules

majnemer updated this revision to Diff 79848. majnemer marked an inline comment as done. majnemer added a comment. - Address review comments https://reviews.llvm.org/D27226 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenCXX/mangle-ms-cxx11.cpp Index: test/CodeGenCXX/mangle-ms-cxx11.cpp ===

[PATCH] D27226: [MS ABI] Implement more of the Itanium mangling rules

rnk added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:838 + if (Func) +LambdaId = Func->getNumParams() - Parm->getFunctionScopeIndex(); + else if (LambdaManglingNumber) Isn't this no good if I have two lambdas in one def

[PATCH] D27226: [MS ABI] Implement more of the Itanium mangling rules

majnemer updated this revision to Diff 79837. majnemer added a comment. - Address review comments https://reviews.llvm.org/D27226 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenCXX/mangle-ms-cxx11.cpp Index: test/CodeGenCXX/mangle-ms-cxx11.cpp ==

[PATCH] D27226: [MS ABI] Implement more of the Itanium mangling rules

rnk added inline comments. Comment at: test/CodeGenCXX/mangle-ms-cxx11.cpp:337 +A a; +} This machinery is also supposed to kick in for lambdas in default arguments, right? Can you add that test case? https://reviews.llvm.org/D27226 _

[PATCH] D27226: [MS ABI] Implement more of the Itanium mangling rules

majnemer created this revision. majnemer added a reviewer: rnk. majnemer added a subscriber: cfe-commits. We didn't implement one of the corner cases: a lambda which belongs to an initializer for a field. In this case, we need to mangle the field name into the lambda. This fixes PR31197. https