[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

This revision was automatically updated to reflect the committed changes. Closed by commit rL288502: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as… (authored by flx). Changed prior to commit: https://reviews.llvm.org/D27248?vs=79732=80066#toc Repository: rL

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

malcolm.parsons added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276 +// Virtual method overrides of dependent types cannot be recognized unless they +// are marked as override or final. Test that check is not triggered on methods +//

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

flx added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276 +// Virtual method overrides of dependent types cannot be recognized unless they +// are marked as override or final. Test that check is not triggered on methods +// marked with

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

alexfh accepted this revision. alexfh added a comment. LG. Looks like a strict improvement. https://reviews.llvm.org/D27248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

malcolm.parsons added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276 +// Virtual method overrides of dependent types cannot be recognized unless they +// are marked as override or final. Test that check is not triggered on methods +//

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

flx removed rL LLVM as the repository for this revision. flx updated this revision to Diff 79732. flx marked an inline comment as done. https://reviews.llvm.org/D27248 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp test/clang-tidy/performance-unnecessary-value-param.cpp

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

flx added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276 +// Virtual method overrides of dependent types cannot be recognized unless they +// are marked as override or final. Test that check is not triggered on methods +// marked with

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

malcolm.parsons added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276 +// Virtual method overrides of dependent types cannot be recognized unless they +// are marked as override or final. Test that check is not triggered on methods +//

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D27248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

flx created this revision. flx added reviewers: sbenza, alexfh, hokein. flx added a subscriber: cfe-commits. flx set the repository for this revision to rL LLVM. flx added a project: clang-tools-extra. Herald added a subscriber: JDevlieghere. Virtual method overrides of dependent types cannot be