ABataev added a comment.
In https://reviews.llvm.org/D27250#609111, @fpetrogalli wrote:
> In https://reviews.llvm.org/D27250#609006, @ABataev wrote:
>
> >
>
>
> Hi! Thanks for your review!
>
> > 1. Please provide full context for your changes (check this document how to
> > do this
fpetrogalli added a comment.
In https://reviews.llvm.org/D27250#609063, @ABataev wrote:
> You did just some minor changes. The main questions are still unanswered.
Hopefully now they are! :)
Francesco
https://reviews.llvm.org/D27250
___
fpetrogalli added a comment.
In https://reviews.llvm.org/D27250#609006, @ABataev wrote:
>
Hi! Thanks for your review!
> 1. Please provide full context for your changes (check this document how to
> do this http://llvm.org/docs/Phabricator.html).
I missed that out, should be done now.
> 2.
fpetrogalli marked 5 inline comments as done.
fpetrogalli added a comment.
I updated the comments related to code formatting.
https://reviews.llvm.org/D27250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev requested changes to this revision.
ABataev added a comment.
This revision now requires changes to proceed.
You did just some minor changes. The main questions are still unanswered.
https://reviews.llvm.org/D27250
___
cfe-commits mailing
fpetrogalli updated this revision to Diff 79734.
fpetrogalli added a comment.
Rebase plus apply clang format.
https://reviews.llvm.org/D27250
Files:
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
ABataev requested changes to this revision.
ABataev added a comment.
This revision now requires changes to proceed.
1. Please provide full context for your changes (check this document how to do
this http://llvm.org/docs/Phabricator.html).
2. Use clang-format for all your changes.
3. Do not use
fpetrogalli created this revision.
fpetrogalli added a reviewer: cfe-commits.
This patch generates a list of global external variables that are
passed to the llvm::TargetLibraryInfo (TLI) to enable the vectorization of
loops containing calls to function that are marked with a #pragma omp
declare
