jlebar added a comment.
This takes it back to how it used to be before I regressed it, which I think is
good enough for now. If we want to revisit how we make this work for
offloading toolchains in general, we can do that separately.
https://reviews.llvm.org/D27316
jhen updated this revision to Diff 80003.
jhen added a comment.
- "Support" ASAN in CudaToolChain
https://reviews.llvm.org/D27316
Files:
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/cuda-no-sanitizers.cu
Index: test/Driver/cuda-no-sanitizers.cu
jhen added a comment.
In https://reviews.llvm.org/D27316#611162, @kcc wrote:
> I am not sure this is going to work.
> You essentially break on the first iteration in the beginning of the loop.
> Why not exit the function before the loop?
> Also, the loop "claims" the args and by breaking
kcc added a comment.
I am not sure this is going to work.
You essentially break on the first iteration in the beginning of the loop.
Why not exit the function before the loop?
Also, the loop "claims" the args and by breaking early you leave the args
unclaimed.
I don't remember this code well
jlebar added a comment.
In https://reviews.llvm.org/D27316#611160, @kcc wrote:
> at the very least this requires a test... Let me thing about the logic a bit
> more...
I think we just need to fix the test from the previous CL, which is buggy and
didn't catch this regression.
kcc added a comment.
at the very least this requires a test... Let me thing about the logic a bit
more...
https://reviews.llvm.org/D27316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jlebar added a comment.
> where would be the right place for me to put a test to check that it is
> working (i.e. ASAN still works for CUDA host code).
I just ran the test from https://reviews.llvm.org/rL281680, and it passes
because it doesn't notice clang raising the "unsupported option
jhen added a reviewer: kcc.
jhen added a comment.
Before this patch, the following command would fail:
clang++ -fsanitize=address --cuda-gpu-arch=sm_20 -c example.cu
with error:
clang-4.0: error: unsupported option '-fsanitize=address' for target
'nvptx64-nvidia-cuda'
After this patch,
jhen created this revision.
jhen added a reviewer: jlebar.
jhen added a subscriber: cfe-commits.
This adds to the work from https://reviews.llvm.org/rL281680. This patch
takes care of another execution path in which sanitizer arguments can be
considered for NVPTX because they are used for the
