[PATCH] D27345: [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D27345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D27345: [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma
kkwli0 marked an inline comment as done. kkwli0 added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:757 Kind == OMPD_distribute_parallel_for_simd || Kind == OMPD_distribute_simd; // TODO add next directives. ABataev wrote: > Should it be added here along with OMPD_teams_distribute_parallel_for_simd? The isOpenMPNestingDistributeDirective is for the construct that has distribute be the outermost (e.g. distribute *) so that it can be checked against the nesting region whether it is teams or not. I do not think it is necessary to add it here. https://reviews.llvm.org/D27345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D27345: [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma
ABataev added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:721 DKind == OMPD_target_parallel_for_simd; // TODO add next directives. } You should consider this new directive as a parallel directive. And OMPD_teams_distribute_parallel_for_simd either. Comment at: lib/Basic/OpenMPKinds.cpp:757 Kind == OMPD_distribute_parallel_for_simd || Kind == OMPD_distribute_simd; // TODO add next directives. Should it be added here along with OMPD_teams_distribute_parallel_for_simd? https://reviews.llvm.org/D27345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
