This revision was automatically updated to reflect the committed changes.
Closed by commit rL288762: [clang] Fix D26214: Move error handling out of MC
and to the callers. (authored by mgrang).
Changed prior to commit:
https://reviews.llvm.org/D27360?vs=80314=80369#toc
Repository:
rL LLVM
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Im not the biggest fan of this. However, having some validation is probably
better than not. We can come up with a better way to address this in the
future when needed I suppose.
mgrang updated this revision to Diff 80314.
https://reviews.llvm.org/D27360
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/Tools.cpp
test/Driver/defsym.s
tools/driver/cc1as_main.cpp
Index: tools/driver/cc1as_main.cpp
mgrang added a comment.
Moved error checking up to the driver and added another test case.
https://reviews.llvm.org/D27360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd added a comment.
I think that the argument parsing should really be hoisted into the driver
rather than pushed down into the assembler. The driver can parse and validate
the options before passing them down, so when cc1as gets it, it will simply set
the value.
The newly introduced
