[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

2016-12-15 Thread Antonio Maiorano via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289909: clang-format-vsix: add a date stamp to the VSIX 
version number to ensure… (authored by amaiorano).

Changed prior to commit:
  https://reviews.llvm.org/D27438?vs=80527=81696#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D27438

Files:
  cfe/trunk/tools/clang-format-vs/CMakeLists.txt


Index: cfe/trunk/tools/clang-format-vs/CMakeLists.txt
===
--- cfe/trunk/tools/clang-format-vs/CMakeLists.txt
+++ cfe/trunk/tools/clang-format-vs/CMakeLists.txt
@@ -11,8 +11,11 @@
   "${CLANG_SOURCE_DIR}/LICENSE.TXT"
   "${CMAKE_CURRENT_SOURCE_DIR}/ClangFormat/license.txt")
 
+  # Build number added to Clang version to ensure that new VSIX can be upgraded
+  string(TIMESTAMP CLANG_FORMAT_VSIX_BUILD %y%m%d%H%M UTC)
+
   if (NOT CLANG_FORMAT_VS_VERSION)
-set(CLANG_FORMAT_VS_VERSION 
"${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}")
+set(CLANG_FORMAT_VS_VERSION 
"${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}.${CLANG_FORMAT_VSIX_BUILD}")
   endif()
 
   configure_file("source.extension.vsixmanifest.in"


Index: cfe/trunk/tools/clang-format-vs/CMakeLists.txt
===
--- cfe/trunk/tools/clang-format-vs/CMakeLists.txt
+++ cfe/trunk/tools/clang-format-vs/CMakeLists.txt
@@ -11,8 +11,11 @@
   "${CLANG_SOURCE_DIR}/LICENSE.TXT"
   "${CMAKE_CURRENT_SOURCE_DIR}/ClangFormat/license.txt")
 
+  # Build number added to Clang version to ensure that new VSIX can be upgraded
+  string(TIMESTAMP CLANG_FORMAT_VSIX_BUILD %y%m%d%H%M UTC)
+
   if (NOT CLANG_FORMAT_VS_VERSION)
-set(CLANG_FORMAT_VS_VERSION "${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}")
+set(CLANG_FORMAT_VS_VERSION "${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}.${CLANG_FORMAT_VSIX_BUILD}")
   endif()
 
   configure_file("source.extension.vsixmanifest.in"
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

2016-12-07 Thread Hans Wennborg via Phabricator via cfe-commits 
hans added a comment.

In https://reviews.llvm.org/D27438#615396, @amaiorano wrote:

> > Yes, I think this is still a worthwhile change. Let's add the hour and 
> > minute and get it landed.
>
> Alright, added hour and minute. How do we land this change? Is this something 
> I can now do myself? Or would you need to commit this for me again?
>
> I have a couple of more interesting changes coming. Perhaps it would make 
> sense to grant me commit rights?


It's worth a shot :-) Follow the instructions at 
http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access to ask Chris 
for commit access.


https://reviews.llvm.org/D27438



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

2016-12-06 Thread Antonio Maiorano via Phabricator via cfe-commits 
amaiorano added a comment.

> Yes, I think this is still a worthwhile change. Let's add the hour and minute 
> and get it landed.

Alright, added hour and minute. How do we land this change? Is this something I 
can now do myself? Or would you need to commit this for me again?

I have a couple of more interesting changes coming. Perhaps it would make sense 
to grant me commit rights?


https://reviews.llvm.org/D27438



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

2016-12-06 Thread Antonio Maiorano via Phabricator via cfe-commits 
amaiorano updated this revision to Diff 80527.
amaiorano added a comment.

Added hour and minute.


https://reviews.llvm.org/D27438

Files:
  tools/clang-format-vs/CMakeLists.txt


Index: tools/clang-format-vs/CMakeLists.txt
===
--- tools/clang-format-vs/CMakeLists.txt
+++ tools/clang-format-vs/CMakeLists.txt
@@ -11,8 +11,11 @@
   "${CLANG_SOURCE_DIR}/LICENSE.TXT"
   "${CMAKE_CURRENT_SOURCE_DIR}/ClangFormat/license.txt")
 
+  # Build number added to Clang version to ensure that new VSIX can be upgraded
+  string(TIMESTAMP CLANG_FORMAT_VSIX_BUILD %y%m%d%H%M UTC)
+
   if (NOT CLANG_FORMAT_VS_VERSION)
-set(CLANG_FORMAT_VS_VERSION 
"${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}")
+set(CLANG_FORMAT_VS_VERSION 
"${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}.${CLANG_FORMAT_VSIX_BUILD}")
   endif()
 
   configure_file("source.extension.vsixmanifest.in"


Index: tools/clang-format-vs/CMakeLists.txt
===
--- tools/clang-format-vs/CMakeLists.txt
+++ tools/clang-format-vs/CMakeLists.txt
@@ -11,8 +11,11 @@
   "${CLANG_SOURCE_DIR}/LICENSE.TXT"
   "${CMAKE_CURRENT_SOURCE_DIR}/ClangFormat/license.txt")
 
+  # Build number added to Clang version to ensure that new VSIX can be upgraded
+  string(TIMESTAMP CLANG_FORMAT_VSIX_BUILD %y%m%d%H%M UTC)
+
   if (NOT CLANG_FORMAT_VS_VERSION)
-set(CLANG_FORMAT_VS_VERSION "${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}")
+set(CLANG_FORMAT_VS_VERSION "${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}.${CLANG_FORMAT_VSIX_BUILD}")
   endif()
 
   configure_file("source.extension.vsixmanifest.in"
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

2016-12-06 Thread Hans Wennborg via Phabricator via cfe-commits 
hans added a comment.

In https://reviews.llvm.org/D27438#614223, @amaiorano wrote:

> In https://reviews.llvm.org/D27438#614219, @hans wrote:
>
> > When building the snapshots and releases, I usually put the SVN revision 
> > number in there to avoid this same problem: 
> > http://llvm-cs.pcc.me.uk/utils/release/build_llvm_package.bat#25
>
>
> Ah, right, I was wondering how that worked. Well, if you don't think it's 
> necessary, we don't have to do it. I didn't realize we had this script to 
> build the official VSIX. Do you think you'd switch to using this method? Or 
> would you prefer that the official releases be bound to the SVN rev number?


I'd prefer to keep the official releases on the SVN rev.

>> Your patch seems like a good default though. Should we put the hour and 
>> minute in there as well, in case one builds multiple versions the same day?
> 
> If you still want this change, I can definitely add the hour and minute. Let 
> me know!

Yes, I think this is still a worthwhile change. Let's add the hour and minute 
and get it landed.


https://reviews.llvm.org/D27438



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

2016-12-05 Thread Antonio Maiorano via Phabricator via cfe-commits 
amaiorano added a comment.

In https://reviews.llvm.org/D27438#614219, @hans wrote:

> When building the snapshots and releases, I usually put the SVN revision 
> number in there to avoid this same problem: 
> http://llvm-cs.pcc.me.uk/utils/release/build_llvm_package.bat#25


Ah, right, I was wondering how that worked. Well, if you don't think it's 
necessary, we don't have to do it. I didn't realize we had this script to build 
the official VSIX. Do you think you'd switch to using this method? Or would you 
prefer that the official releases be bound to the SVN rev number?

> Your patch seems like a good default though. Should we put the hour and 
> minute in there as well, in case one builds multiple versions the same day?

If you still want this change, I can definitely add the hour and minute. Let me 
know!


https://reviews.llvm.org/D27438



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

2016-12-05 Thread Hans Wennborg via Phabricator via cfe-commits 
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

When building the snapshots and releases, I usually put the SVN revision number 
in there to avoid this same problem: 
http://llvm-cs.pcc.me.uk/utils/release/build_llvm_package.bat#25

Your patch seems like a good default though. Should we put the hour and minute 
in there as well, in case one builds multiple versions the same day?


https://reviews.llvm.org/D27438



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

2016-12-05 Thread Antonio Maiorano via Phabricator via cfe-commits 
amaiorano created this revision.
amaiorano added reviewers: klimek, hans, zturner.
amaiorano added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.

Presently, the version number of the VSIX matches the LLVM version number. 
However, as this number doesn't change often, it means that as we release new 
versions of this VSIX, it will have the same version number, which means users 
must first uninstall the old version before installing the new one. With this 
change, we generate a 4th part to the version number that is a date stamp 
(year, month, day); for example: 4.0.0.161203.


https://reviews.llvm.org/D27438

Files:
  tools/clang-format-vs/CMakeLists.txt


Index: tools/clang-format-vs/CMakeLists.txt
===
--- tools/clang-format-vs/CMakeLists.txt
+++ tools/clang-format-vs/CMakeLists.txt
@@ -11,8 +11,11 @@
   "${CLANG_SOURCE_DIR}/LICENSE.TXT"
   "${CMAKE_CURRENT_SOURCE_DIR}/ClangFormat/license.txt")
 
+  # Build number added to Clang version to ensure that new VSIX can be upgraded
+  string(TIMESTAMP CLANG_FORMAT_VSIX_BUILD %y%m%d UTC)
+
   if (NOT CLANG_FORMAT_VS_VERSION)
-set(CLANG_FORMAT_VS_VERSION 
"${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}")
+set(CLANG_FORMAT_VS_VERSION 
"${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}.${CLANG_FORMAT_VSIX_BUILD}")
   endif()
 
   configure_file("source.extension.vsixmanifest.in"


Index: tools/clang-format-vs/CMakeLists.txt
===
--- tools/clang-format-vs/CMakeLists.txt
+++ tools/clang-format-vs/CMakeLists.txt
@@ -11,8 +11,11 @@
   "${CLANG_SOURCE_DIR}/LICENSE.TXT"
   "${CMAKE_CURRENT_SOURCE_DIR}/ClangFormat/license.txt")
 
+  # Build number added to Clang version to ensure that new VSIX can be upgraded
+  string(TIMESTAMP CLANG_FORMAT_VSIX_BUILD %y%m%d UTC)
+
   if (NOT CLANG_FORMAT_VS_VERSION)
-set(CLANG_FORMAT_VS_VERSION "${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}")
+set(CLANG_FORMAT_VS_VERSION "${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}.${CLANG_FORMAT_VSIX_BUILD}")
   endif()
 
   configure_file("source.extension.vsixmanifest.in"
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits