This revision was automatically updated to reflect the committed changes.
Closed by commit rL291253: Make ASTContext::getDeclAlign return the correct
alignment for (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D27478?vs=80464&id=83378#toc
Repository:
rL LLVM
http
arphaman accepted this revision.
arphaman added a reviewer: arphaman.
arphaman added a comment.
This revision is now accepted and ready to land.
Thanks. LGTM, I think the patch makes sense.
https://reviews.llvm.org/D27478
___
cfe-commits mailing lis
ahatanak added a comment.
ping
https://reviews.llvm.org/D27478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added a comment.
ping
https://reviews.llvm.org/D27478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added a comment.
This doesn't happen for objective-c block pointers. Sema::CheckCastAlign
returns early when the type isn't a PointerType (BlockPointerType isn't a
subclass of PointerType).
https://reviews.llvm.org/D27478
___
cfe-commits
arphaman added a comment.
Does this happen with blocks as well?
https://reviews.llvm.org/D27478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak updated this revision to Diff 80464.
ahatanak added a comment.
Call getTypeInfoImpl from getDeclAlign to get the alignment of functions.
https://reviews.llvm.org/D27478
Files:
lib/AST/ASTContext.cpp
test/Sema/warn-cast-align.c
Index: test/Sema/warn-cast-align.c
==
ahatanak created this revision.
ahatanak added reviewers: rsmith, doug.gregor.
ahatanak added a subscriber: cfe-commits.
This patch silences an incorrect warning that is issued when a function pointer
is cast to another function pointer type. The warning gets issued because
alignments of the sou
