[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-15 Thread Antonio Maiorano via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289910: clang-format-vsix: add command to format document (authored by amaiorano). Changed prior to commit: https://reviews.llvm.org/D27501?vs=80533&id=81701#toc Repository: rL LLVM https://reviews.

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-12 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + klimek wrote: > amaiorano wrote: > > klimek wrote: > > > hans wrote: > > > > amaiorano wrote: > > > > > hans wr

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-12 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. I also think it makes the code nicer by breaking out the right functions. Thanks! Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + +

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-09 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano added a comment. (NOTE, I forgot to click Submit on the reply to @klimek a couple days ago!) Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + klimek wrote: > hans wrote: > > amaiora

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-08 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + hans wrote: > amaiorano wrote: > > hans wrote: > > > I think File would be better than Document when referring to

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-07 Thread Hans Wennborg via Phabricator via cfe-commits
hans added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + amaiorano wrote: > hans wrote: > > I think File would be better than Document when referring to source code. > > >

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-07 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + hans wrote: > I think File would be better than Document when referring to source code. > > But it seems a lit

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-07 Thread Hans Wennborg via Phabricator via cfe-commits
hans added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + I think File would be better than Document when referring to source code. But it seems a little annoying to need tw

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-06 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano updated this revision to Diff 80533. amaiorano added a comment. My first patch accidentally included the changes from https://reviews.llvm.org/D27440 https://reviews.llvm.org/D27501 Files: tools/clang-format-vs/.gitignore tools/clang-format-vs/ClangFormat/ClangFormat.vsct tools

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-06 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano created this revision. amaiorano added reviewers: hans, zturner, klimek. amaiorano added a subscriber: cfe-commits. Bound to Ctrl+R, Ctrl+D by default. Also added section on how to debug the extension to the Readme. https://reviews.llvm.org/D27501 Files: tools/clang-format-vs/.giti