This revision was automatically updated to reflect the committed changes.
Closed by commit rL289910: clang-format-vsix: add command to format document
(authored by amaiorano).
Changed prior to commit:
https://reviews.llvm.org/D27501?vs=80533&id=81701#toc
Repository:
rL LLVM
https://reviews.
amaiorano added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76
+
+ Clang Format Document
+
klimek wrote:
> amaiorano wrote:
> > klimek wrote:
> > > hans wrote:
> > > > amaiorano wrote:
> > > > > hans wr
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. I also think it makes the code nicer by breaking out the right functions.
Thanks!
Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76
+
+
amaiorano added a comment.
(NOTE, I forgot to click Submit on the reply to @klimek a couple days ago!)
Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76
+
+ Clang Format Document
+
klimek wrote:
> hans wrote:
> > amaiora
klimek added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76
+
+ Clang Format Document
+
hans wrote:
> amaiorano wrote:
> > hans wrote:
> > > I think File would be better than Document when referring to
hans added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76
+
+ Clang Format Document
+
amaiorano wrote:
> hans wrote:
> > I think File would be better than Document when referring to source code.
> >
>
amaiorano added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76
+
+ Clang Format Document
+
hans wrote:
> I think File would be better than Document when referring to source code.
>
> But it seems a lit
hans added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76
+
+ Clang Format Document
+
I think File would be better than Document when referring to source code.
But it seems a little annoying to need tw
amaiorano updated this revision to Diff 80533.
amaiorano added a comment.
My first patch accidentally included the changes from
https://reviews.llvm.org/D27440
https://reviews.llvm.org/D27501
Files:
tools/clang-format-vs/.gitignore
tools/clang-format-vs/ClangFormat/ClangFormat.vsct
tools
amaiorano created this revision.
amaiorano added reviewers: hans, zturner, klimek.
amaiorano added a subscriber: cfe-commits.
Bound to Ctrl+R, Ctrl+D by default. Also added section on how to debug the
extension to the Readme.
https://reviews.llvm.org/D27501
Files:
tools/clang-format-vs/.giti
10 matches
Mail list logo